Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed regula from github actions and codebase #837

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

bigbitbus
Copy link
Contributor

Description

Removing regula from GH actions, since we are adopting tfsec.

Safety checklist

  • [ X] This change is backwards compatible and safe to apply by existing users
  • [ X] This change will NOT lead to data loss
  • [ X] This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

Manually

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #837 (76ec0c3) into main (7a537a1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #837   +/-   ##
=======================================
  Coverage   74.06%   74.06%           
=======================================
  Files         119      119           
  Lines        7821     7821           
=======================================
  Hits         5793     5793           
  Misses       2028     2028           
Flag Coverage Δ
unittests 74.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a537a1...76ec0c3. Read the comment docs.

@nsarupr
Copy link
Contributor

nsarupr commented Apr 18, 2022

@bigbitbus bigbitbus merged commit 0317ca4 into main Apr 18, 2022
@bigbitbus bigbitbus deleted the feature/remove-regula branch April 18, 2022 20:53
@rabbitfang rabbitfang mentioned this pull request Apr 19, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants