Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tfsec high removal #847

Merged
merged 9 commits into from
Apr 21, 2022
Merged

Feature/tfsec high removal #847

merged 9 commits into from
Apr 21, 2022

Conversation

bigbitbus
Copy link
Contributor

Description

Adding ignore comments for tfsec

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

Only comments, no code changes.

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #847 (9d0b8ba) into main (1fad4d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage   73.96%   73.96%           
=======================================
  Files         120      120           
  Lines        7905     7905           
=======================================
  Hits         5847     5847           
  Misses       2058     2058           
Flag Coverage Δ
unittests 73.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fad4d5...9d0b8ba. Read the comment docs.

@bigbitbus bigbitbus added the WIP Work in progress label Apr 21, 2022
@bigbitbus bigbitbus removed the request for review from juandiegopalomino April 21, 2022 16:29
@bigbitbus bigbitbus merged commit 4ace92e into main Apr 21, 2022
@bigbitbus bigbitbus deleted the feature/tfsec-high-removal branch April 21, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants