Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding warnings for opta destroy and how to start debugging #855

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

juandiegopalomino
Copy link
Collaborator

Description

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

Manually

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #855 (0c14bd8) into main (7ad9474) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
- Coverage   73.86%   73.76%   -0.10%     
==========================================
  Files         120      120              
  Lines        7916     7959      +43     
==========================================
+ Hits         5847     5871      +24     
- Misses       2069     2088      +19     
Flag Coverage Δ
unittests 73.76% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
opta/cli.py 72.22% <ø> (ø)
opta/commands/destroy.py 57.24% <100.00%> (+0.29%) ⬆️
opta/core/kubernetes.py 46.22% <0.00%> (-1.77%) ⬇️
opta/core/secrets.py 62.50% <0.00%> (-1.14%) ⬇️
opta/commands/secret.py 89.83% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad9474...0c14bd8. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit 7ddf8b0 into main Apr 26, 2022
@juandiegopalomino juandiegopalomino deleted the jd/warnings branch April 26, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants