Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change opta sub command #857

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Change opta sub command #857

merged 1 commit into from
Apr 28, 2022

Conversation

nsarupr
Copy link
Contributor

@nsarupr nsarupr commented Apr 28, 2022

Description

Change the opta sub-command config to show to support future sub command usages.

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

YOUR_ANSWER

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #857 (f28d409) into main (820cacc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   73.73%   73.73%           
=======================================
  Files         121      121           
  Lines        7976     7976           
=======================================
  Hits         5881     5881           
  Misses       2095     2095           
Flag Coverage Δ
unittests 73.73% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
opta/cli.py 72.97% <100.00%> (ø)
opta/commands/show.py 85.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 820cacc...f28d409. Read the comment docs.

@nsarupr nsarupr force-pushed the runx-1285-sub-command-change branch from 7c5f2d5 to f28d409 Compare April 28, 2022 19:56
@nsarupr nsarupr merged commit f69476a into main Apr 28, 2022
@nsarupr nsarupr deleted the runx-1285-sub-command-change branch April 28, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants