show tf-state for AWS and GCP #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #859 +/- ##
==========================================
- Coverage 73.73% 73.72% -0.01%
==========================================
Files 121 121
Lines 7976 8099 +123
==========================================
+ Hits 5881 5971 +90
- Misses 2095 2128 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| def get_remote_state(self) -> str: | ||
| bucket = self.layer.state_storage() | ||
| s3_client = boto3.client("s3", config=Config(region_name=self.region)) | ||
| tf_state = self._download_remote_blob(s3_client, bucket, self.layer.name) |
There was a problem hiding this comment.
this works? I thought the path to the object started with /tfstate
There was a problem hiding this comment.
I took this path from the delete_remote_state method here
Line 144 in 63934b7
There was a problem hiding this comment.
can you run the show command to make sure it works?
added 2 commits
May 2, 2022 18:07
nsarupr
requested review from
juandiegopalomino,
rabbitfang,
RemyDeWolf and
NitinAgg
juandiegopalomino
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get the Terraform State for the given Opta configuration.
Safety checklist
How has this change been tested, beside unit tests?
Tested Manually