Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating azure cause microsoft broke backwards compatibility #862

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

juandiegopalomino
Copy link
Collaborator

Description

https://opta-group.slack.com/archives/C0240NBKUMT/p1651244371698299

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

Manually

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #862 (c967216) into main (63934b7) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
- Coverage   73.75%   73.73%   -0.03%     
==========================================
  Files         121      121              
  Lines        7983     7983              
==========================================
- Hits         5888     5886       -2     
- Misses       2095     2097       +2     
Flag Coverage Δ
unittests 73.73% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
opta/datadog_logging.py 86.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63934b7...c967216. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants