Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for azure #866

Merged
merged 1 commit into from
May 4, 2022
Merged

Small fix for azure #866

merged 1 commit into from
May 4, 2022

Conversation

juandiegopalomino
Copy link
Collaborator

Description

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

YOUR_ANSWER

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #866 (d224ebe) into main (41b8301) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   73.46%   73.46%   -0.01%     
==========================================
  Files         122      122              
  Lines        8130     8132       +2     
==========================================
+ Hits         5973     5974       +1     
- Misses       2157     2158       +1     
Flag Coverage Δ
unittests 73.46% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
opta/module.py 85.60% <50.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b8301...d224ebe. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit f474a4d into main May 4, 2022
@juandiegopalomino juandiegopalomino deleted the jd/azure-fix branch May 4, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant