Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing k8s manifest #873

Merged
merged 4 commits into from
May 10, 2022
Merged

Fixing k8s manifest #873

merged 4 commits into from
May 10, 2022

Conversation

juandiegopalomino
Copy link
Collaborator

Description

K8s manifest will no longer rely on the kubeconfig file or make any alterations thereof. All the data of the cofniguration for cluster communication is taken care of internally in a similar manner of that of the helm provider

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

Manually

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@46ddfa4). Click here to learn what that means.
The diff coverage is 52.45%.

@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage        ?   73.48%           
=======================================
  Files           ?      123           
  Lines           ?     8188           
  Branches        ?        0           
=======================================
  Hits            ?     6017           
  Misses          ?     2171           
  Partials        ?        0           
Flag Coverage Δ
unittests 73.48% <52.45%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/k8s_manifest/k8s_manifest.py 49.09% <37.50%> (ø)
opta/layer.py 85.38% <78.94%> (ø)
modules/k8s_manifest/tests/test_k8s_manifest.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ddfa4...b0863ff. Read the comment docs.

K8s manifest will no longer rely on the kubeconfig file or make any alterations thereof. All the data of the cofniguration for cluster communication is taken care of internally in a similar manner of that of the helm provider
Copy link
Contributor

@nsarupr nsarupr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me..

@juandiegopalomino juandiegopalomino merged commit 5f1404d into main May 10, 2022
@juandiegopalomino juandiegopalomino deleted the jd/k8s-manifest-fix-3 branch May 10, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants