Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BYOK clusters to opta logs #874

Merged
merged 1 commit into from
May 10, 2022

Conversation

rabbitfang
Copy link
Collaborator

Description

  • Adds support for opta logs to BYOK clusters.
  • opta secret and opta shell already seem to work just fine without any additional changes for BYOK clusters

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

Manually verified that I could run opta logs, opta shell, and opta secret with a k8s-service only opta file that doesn't contain an environment.

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #874 (690154d) into main (46ddfa4) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
- Coverage   73.51%   73.46%   -0.05%     
==========================================
  Files         123      123              
  Lines        8159     8190      +31     
==========================================
+ Hits         5998     6017      +19     
- Misses       2161     2173      +12     
Flag Coverage Δ
unittests 73.46% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
opta/commands/logs.py 75.60% <0.00%> (-3.88%) ⬇️
modules/k8s_manifest/k8s_manifest.py 49.09% <0.00%> (-4.76%) ⬇️
opta/layer.py 85.38% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ddfa4...690154d. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit ddeaf5c into main May 10, 2022
@juandiegopalomino juandiegopalomino deleted the feature/byok-logs branch May 10, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants