Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid Micro and Nano instances in aws eks #875

Merged
merged 3 commits into from
May 11, 2022

Conversation

nsarupr
Copy link
Contributor

@nsarupr nsarupr commented May 10, 2022

Description

Forbid users from using micro and nano instances in AWS EKS.

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

Tested and validated manually.

name: testenv
org_name: runx
providers:
  aws:
    region: us-east-1
    account_id: 000000000000
modules:
  - type: base
  - type: k8s-cluster
    node_instance_type: "t2.nano"
  - type: k8s-base
$> opta apply -c aws-env.yml
Opta file validation failed with errors:
  : modules.1: node_instance_type: t2.nano is not a regex match.
ERROR: aws-env.yml is not a valid Opta file.
If you need more help please reach out to the contributors in our slack channel at: https://slack.opta.dev

Copy link
Collaborator

@juandiegopalomino juandiegopalomino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also on the nodegroup

@nsarupr
Copy link
Contributor Author

nsarupr commented May 10, 2022

also on the nodegroup

I thought there we should let the users have an option to have a lesser instance type

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #875 (3e1ab6f) into main (5f1404d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   73.48%   73.46%   -0.02%     
==========================================
  Files         123      123              
  Lines        8188     8190       +2     
==========================================
  Hits         6017     6017              
- Misses       2171     2173       +2     
Flag Coverage Δ
unittests 73.46% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
opta/commands/logs.py 75.60% <0.00%> (-3.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1404d...3e1ab6f. Read the comment docs.

@nsarupr nsarupr force-pushed the runx-1289-forbid-micro-nano-instances branch from 03191c5 to 3e1ab6f Compare May 10, 2022 20:08
@juandiegopalomino juandiegopalomino merged commit d4e781a into main May 11, 2022
@juandiegopalomino juandiegopalomino deleted the runx-1289-forbid-micro-nano-instances branch May 11, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants