Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding release name to helm chart module #877

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

juandiegopalomino
Copy link
Collaborator

Description

Made sure to be backwards compatible with existing releases

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

Manually

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #877 (7ea5694) into main (c5a4c75) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   73.46%   73.46%           
=======================================
  Files         123      123           
  Lines        8190     8190           
=======================================
  Hits         6017     6017           
  Misses       2173     2173           
Flag Coverage Δ
unittests 73.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a4c75...7ea5694. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit 41c4c45 into main May 11, 2022
@juandiegopalomino juandiegopalomino deleted the jd/release-name branch May 11, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants