Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point deployment readiness probe to readiness probe endpoint #883

Merged
merged 1 commit into from
May 17, 2022

Conversation

0AdityaD
Copy link
Contributor

Description

see title

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

It has not

@0AdityaD 0AdityaD marked this pull request as ready for review May 17, 2022 06:30
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #883 (dadc5cf) into main (618ae27) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #883   +/-   ##
=======================================
  Coverage   73.46%   73.46%           
=======================================
  Files         123      123           
  Lines        8190     8190           
=======================================
  Hits         6017     6017           
  Misses       2173     2173           
Flag Coverage Δ
unittests 73.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 618ae27...dadc5cf. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit fa25951 into run-x:main May 17, 2022
@0AdityaD 0AdityaD deleted the patch-1 branch May 17, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants