Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to make a exec command health probes #885

Merged
merged 3 commits into from
May 20, 2022

Conversation

juandiegopalomino
Copy link
Collaborator

Description

At the behest of our users
#876

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

manually

At the behest of our beloved users
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #885 (9b66e0d) into main (66df515) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   72.91%   72.90%   -0.01%     
==========================================
  Files         123      122       -1     
  Lines        8280     8279       -1     
==========================================
- Hits         6037     6036       -1     
  Misses       2243     2243              
Flag Coverage Δ
unittests 72.90% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/base.py 77.75% <75.00%> (-0.06%) ⬇️
opta/cli.py 72.22% <0.00%> (-0.76%) ⬇️
opta/commands/ui.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66df515...9b66e0d. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit 6311039 into main May 20, 2022
@juandiegopalomino juandiegopalomino deleted the jd/healthcheckcommand branch May 20, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants