Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to simplify cloudfront usage #892

Merged
merged 2 commits into from
May 23, 2022

Conversation

juandiegopalomino
Copy link
Collaborator

Description

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

YOUR_ANSWER

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #892 (0f30551) into main (34e7be6) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   72.93%   72.90%   -0.03%     
==========================================
  Files         122      122              
  Lines        8279     8279              
==========================================
- Hits         6038     6036       -2     
- Misses       2241     2243       +2     
Flag Coverage Δ
unittests 72.90% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cloudfront_distribution/cloudfront_distribution.py 67.92% <ø> (ø)
opta/datadog_logging.py 86.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e7be6...0f30551. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit 213ba4d into main May 23, 2022
@juandiegopalomino juandiegopalomino deleted the jd/cloudfrontfixes branch May 23, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant