Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#894 Add waits_for_job to Opta YAML for Helm Chart module type #895

Merged
merged 1 commit into from
May 31, 2022

Conversation

edeesis
Copy link
Contributor

@edeesis edeesis commented May 24, 2022

Description

Add waits_for_job to Helm Chart module

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

Tested locally

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #895 (b217628) into main (213ba4d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage   72.90%   72.90%           
=======================================
  Files         122      122           
  Lines        8279     8279           
=======================================
  Hits         6036     6036           
  Misses       2243     2243           
Flag Coverage Δ
unittests 72.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213ba4d...b217628. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit 1b6d77b into run-x:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants