Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding args and commands variable to k8s service and its cron jobs #915

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

juandiegopalomino
Copy link
Collaborator

Description

To resolve:
#911

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

manually

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #915 (85c9dc7) into main (54021f1) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   72.91%   72.91%   -0.01%     
==========================================
  Files         122      122              
  Lines        8282     8285       +3     
==========================================
+ Hits         6039     6041       +2     
- Misses       2243     2244       +1     
Flag Coverage Δ
unittests 72.91% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/base.py 77.67% <66.66%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54021f1...85c9dc7. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit 94418a5 into main Jul 1, 2022
@juandiegopalomino juandiegopalomino deleted the jd/args-and-commands branch July 1, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant