Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding providers data to output #917

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Conversation

juandiegopalomino
Copy link
Collaborator

@juandiegopalomino juandiegopalomino commented Jul 4, 2022

Description

For
#910

{
    .
    .
    .
    "providers": {
        "aws": {
            "account_id": "XXXXXXX",
            "region": "us-east-1"
        }
    },
    .
    .
    .
}

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

manually

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #917 (033b1e2) into main (17f347c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
- Coverage   72.93%   72.91%   -0.02%     
==========================================
  Files         122      122              
  Lines        8286     8290       +4     
==========================================
+ Hits         6043     6045       +2     
- Misses       2243     2245       +2     
Flag Coverage Δ
unittests 72.91% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
opta/layer.py 84.66% <100.00%> (+0.14%) ⬆️
opta/datadog_logging.py 86.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f347c...033b1e2. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit 294f05d into main Jul 5, 2022
@juandiegopalomino juandiegopalomino deleted the jd/account-id-variable branch July 5, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant