Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates due to tls update in terraform #924

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Conversation

juandiegopalomino
Copy link
Collaborator

Description

key algorithm is now inferred from key and doesn't need to be specified again

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

manually

key algorithm is now inferred from key and doesn't need to be specified again
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #924 (40c6166) into main (f5ee3df) will not change coverage.
The diff coverage is n/a.

❗ Current head 40c6166 differs from pull request most recent head 2d37bb2. Consider uploading reports for the commit 2d37bb2 to get more accurate results

@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage   72.91%   72.91%           
=======================================
  Files         122      122           
  Lines        8290     8290           
=======================================
  Hits         6045     6045           
  Misses       2245     2245           
Flag Coverage Δ
unittests 72.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ee3df...2d37bb2. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit 7b791ee into main Jul 21, 2022
@juandiegopalomino juandiegopalomino deleted the jd/updating-tls branch July 21, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant