Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to BucketOwnerEnforced s3 bucket ownership controls #929

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

0AdityaD
Copy link
Contributor

@0AdityaD 0AdityaD commented Jul 28, 2022

Description

It's useful when you have objects in the s3 bucket which are created by other aws accounts not owned by you.

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

It has been tested by attaching the code as custom-terraform to an s3 bucket provisioned via opta

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #929 (8c080fb) into main (78b0087) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #929   +/-   ##
=======================================
  Coverage   72.81%   72.81%           
=======================================
  Files         118      118           
  Lines        7994     7994           
=======================================
  Hits         5821     5821           
  Misses       2173     2173           
Flag Coverage Δ
unittests 72.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b0087...8c080fb. Read the comment docs.

@juandiegopalomino juandiegopalomino merged commit ce5d57f into run-x:main Aug 1, 2022
@0AdityaD 0AdityaD deleted the patch-1 branch August 3, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants