Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upgrade and upgrade check #933

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Remove upgrade and upgrade check #933

merged 4 commits into from
Aug 16, 2022

Conversation

NitinAgg
Copy link
Collaborator

Description

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

YOUR_ANSWER

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #933 (42106ea) into main (e0b7ed2) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
- Coverage   71.67%   71.51%   -0.16%     
==========================================
  Files         118      116       -2     
  Lines        7994     7907      -87     
==========================================
- Hits         5730     5655      -75     
+ Misses       2264     2252      -12     
Flag Coverage Δ
unittests 71.51% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
opta/cli.py 73.84% <ø> (-0.07%) ⬇️
opta/commands/apply.py 78.72% <0.00%> (-0.66%) ⬇️
opta/commands/output.py 92.30% <ø> (-0.38%) ⬇️
opta/utils/globals.py 0.00% <0.00%> (-75.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@NitinAgg NitinAgg merged commit 15316f4 into main Aug 16, 2022
@NitinAgg NitinAgg deleted the remove-upgrade branch August 16, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant