extract workspace_step_runner_delegate from plan_step_runner

server/controllers/events/events_controller_e2e_test.go

@@ -1069,6 +1069,7 @@ func setupE2E(t *testing.T, repoDir string, opt setupOption) (events_controllers
 	silenceNoProjects := false
 
 	commitStatusUpdater := mocks.NewMockCommitStatusUpdater()
+	asyncTfExec := runtimemocks.NewMockAsyncTFExec()
 
 	mockPreWorkflowHookRunner = runtimemocks.NewMockPreWorkflowHookRunner()
 	preWorkflowHookURLGenerator := mocks.NewMockPreWorkflowHookURLGenerator()
@@ -1139,10 +1140,12 @@ func setupE2E(t *testing.T, repoDir string, opt setupOption) (events_controllers
 			TerraformExecutor: terraformClient,
 			DefaultTFVersion:  defaultTFVersion,
 		},
-		PlanStepRunner: &runtime.PlanStepRunner{
-			TerraformExecutor: terraformClient,
-			DefaultTFVersion:  defaultTFVersion,
-		},
+		PlanStepRunner: runtime.NewPlanStepRunner(
+			terraformClient,
+			defaultTFVersion,
+			commitStatusUpdater,
+			asyncTfExec,
+		),
 		ShowStepRunner:        showStepRunner,
 		PolicyCheckStepRunner: policyCheckRunner,
 		ApplyStepRunner: &runtime.ApplyStepRunner{

server/core/runtime/minimum_version_step_runner_delegate.go

@@ -8,9 +8,9 @@ import (
 	"github.com/runatlantis/atlantis/server/events/command"
 )
 
-// MinimumVersionStepRunnerDelegate ensures that a given step runner can't run unless the command version being used
+// minimumVersionStepRunnerDelegate ensures that a given step runner can't run unless the command version being used
 // is greater than a provided minimum
-type MinimumVersionStepRunnerDelegate struct {
+type minimumVersionStepRunnerDelegate struct {
 	minimumVersion   *version.Version
 	defaultTfVersion *version.Version
 	delegate         Runner
@@ -20,17 +20,17 @@ func NewMinimumVersionStepRunnerDelegate(minimumVersionStr string, defaultVersio
 	minimumVersion, err := version.NewVersion(minimumVersionStr)
 
 	if err != nil {
-		return &MinimumVersionStepRunnerDelegate{}, errors.Wrap(err, "initializing minimum version")
+		return &minimumVersionStepRunnerDelegate{}, errors.Wrap(err, "initializing minimum version")
 	}
 
-	return &MinimumVersionStepRunnerDelegate{
+	return &minimumVersionStepRunnerDelegate{
 		minimumVersion:   minimumVersion,
 		defaultTfVersion: defaultVersion,
 		delegate:         delegate,
 	}, nil
 }
 
-func (r *MinimumVersionStepRunnerDelegate) Run(ctx command.ProjectContext, extraArgs []string, path string, envs map[string]string) (string, error) {
+func (r *minimumVersionStepRunnerDelegate) Run(ctx command.ProjectContext, extraArgs []string, path string, envs map[string]string) (string, error) {
 	tfVersion := r.defaultTfVersion
 	if ctx.TerraformVersion != nil {
 		tfVersion = ctx.TerraformVersion

server/core/runtime/minimum_version_step_runner_delegate_test.go

@@ -26,7 +26,7 @@ func TestRunMinimumVersionDelegate(t *testing.T) {
 	expectedOut := "some valid output from delegate"
 
 	t.Run("default version success", func(t *testing.T) {
-		subject := &MinimumVersionStepRunnerDelegate{
+		subject := &minimumVersionStepRunnerDelegate{
 			defaultTfVersion: tfVersion12,
 			minimumVersion:   tfVersion12,
 			delegate:         mockDelegate,
@@ -48,7 +48,7 @@ func TestRunMinimumVersionDelegate(t *testing.T) {
 	})
 
 	t.Run("ctx version success", func(t *testing.T) {
-		subject := &MinimumVersionStepRunnerDelegate{
+		subject := &minimumVersionStepRunnerDelegate{
 			defaultTfVersion: tfVersion11,
 			minimumVersion:   tfVersion12,
 			delegate:         mockDelegate,
@@ -72,7 +72,7 @@ func TestRunMinimumVersionDelegate(t *testing.T) {
 	})
 
 	t.Run("default version failure", func(t *testing.T) {
-		subject := &MinimumVersionStepRunnerDelegate{
+		subject := &minimumVersionStepRunnerDelegate{
 			defaultTfVersion: tfVersion11,
 			minimumVersion:   tfVersion12,
 			delegate:         mockDelegate,
@@ -94,7 +94,7 @@ func TestRunMinimumVersionDelegate(t *testing.T) {
 	})
 
 	t.Run("ctx version failure", func(t *testing.T) {
-		subject := &MinimumVersionStepRunnerDelegate{
+		subject := &minimumVersionStepRunnerDelegate{
 			defaultTfVersion: tfVersion12,
 			minimumVersion:   tfVersion12,
 			delegate:         mockDelegate,