Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureDevOps - Apply not respecting PR policy #970

Closed
jpreese opened this issue Apr 2, 2020 · 3 comments
Closed

AzureDevOps - Apply not respecting PR policy #970

jpreese opened this issue Apr 2, 2020 · 3 comments

Comments

@jpreese
Copy link
Contributor

jpreese commented Apr 2, 2020

Our repository has a minimum reviewer policy set, requiring at least two reviewers, but Atlantis allowed the apply to go through successfully.

Both the approved and mergeable attributes are set in the server side config.

78273259-9afb2980-74dc-11ea-9ab5-b58ea02e9379

After doing some digging into AzureDevOps API some, it may actually be on their end as it's reporting as a successful merge status.

@lkysow
Copy link
Member

lkysow commented Apr 3, 2020

@mcdafydd might be able to help with this

@jpreese
Copy link
Contributor Author

jpreese commented Apr 4, 2020

This is most likely on Azure's end.

This just seems like a large enough gap that I wanted to see if anyone else was experiencing a similar problem.

@jpreese
Copy link
Contributor Author

jpreese commented Apr 16, 2020

Resolved via #984

@jpreese jpreese closed this as completed Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants