Add policy evaluations #6
Merged
+203
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpreese
force-pushed
the
policy-evals
branch
2 times, most recently
from
758a7f6 to
ea8e7c7
Compare
|
Looks good to me! Thanks @jpreese |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of runatlantis/atlantis#970
Right now in Atlantis we're checking the
mergeStatusfield on thepullRequestsAPI to see whether or not a PR is mergeable. Currently its always returning a value ofsucceeded.. which doesn't help when trying to assess whether or not a policy has been violated!However, there is a
policy/evaluationsAPI (https://docs.microsoft.com/en-us/rest/api/azure/devops/policy/evaluations/list?view=azure-devops-rest-5.1) that we can create an artifactID from, using theprojectIDandpullRequestIDand query if any policies have been violated on the pull request.