Add "plan" to continued output statement

[crainte]

Related to #1021

It looks like if the word "Plan" is added in the first line of comments made by atlantis hiding will work. Edited all vcs comments for consistency.

[codecov]

Codecov Report

Merging #1034 into master will decrease coverage by 0.05%.
The diff coverage is 10.00%.

@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
- Coverage   70.97%   70.91%   -0.06%     
==========================================
  Files          71       71              
  Lines        5870     5876       +6     
==========================================
+ Hits         4166     4167       +1     
- Misses       1357     1362       +5     
  Partials      347      347              

Impacted Files	Coverage Δ
server/events/vcs/azuredevops_client.go	66.82% <0.00%> (ø)
server/events/vcs/bitbucketcloud/client.go	47.40% <0.00%> (ø)
server/events/vcs/bitbucketserver/client.go	35.63% <0.00%> (ø)
server/events/vcs/github_client.go	79.68% <0.00%> (-2.14%)	⬇️
server/events/vcs/gitlab_client.go	39.66% <0.00%> (ø)
server/events/vcs/not_configured_vcs_client.go	0.00% <0.00%> (ø)
server/events/vcs/proxy.go	0.00% <0.00%> (ø)
server/events_controller.go	57.75% <0.00%> (ø)
server/events/command_runner.go	53.61% <9.09%> (+0.15%)	⬆️
server/events/pull_closed_executor.go	89.74% <100.00%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc55ba3...aa1bfc0. Read the comment docs.

[lkysow]

This comment splitting applies to both apply and plan comments so this isn't accurate. I think you need to pass the type of comment and only add plan if it's actually a plan comment.

[crainte]

@lkysow maybe I should change my approach. Instead of adding the word "plan" here should I just expand the matching located here: https://github.com/runatlantis/atlantis/blob/master/server/events/vcs/github_client.go#L168-L179 ?

That would allow hiding of failed applies or discarding of locks via the UI.

[lkysow]

@crainte I don't think we want to hide failing applies because a partial apply may still make some changes.

[crainte]

That's a good point. I'll move ahead with your suggestion of passing the type.

[Ninir]

@crainte @lkysow hey folks, anything we can do to help this cross the finish line?

[lkysow]

I'm waiting for the PR to be ready for review before I look at it.

[crainte]

Looks like I need to rebase, I'll do that shortly. I'm not exactly thrilled with this because it looks like i'm abusing models.ApplyCommand when an error comment is created. I was waiting to see what your comments were going to be like for #1060 since that might be a cleaner option.

edit: rebased

[lkysow]

Let's take in a string to CreateComment instead of a CommandName and then for error we can use empty string.

[lkysow]

Looks good, just one small change. Can you squash all your commits as well please.

[lkysow]

🎉

[lkysow]

Fixes #1021 .