Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GraphQL URL for Github Enterprise #1072

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

goodspark
Copy link

@goodspark goodspark commented Jun 3, 2020

Partially addresses #1009, but doesn't fix it entirely. The 406 response
is still a puzzler.

@goodspark goodspark force-pushed the fix-ge-graphql-endpoint branch from 02c4865 to 37465a9 Compare June 3, 2020 18:13
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #1072 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1072   +/-   ##
=======================================
  Coverage   71.49%   71.49%           
=======================================
  Files          67       67           
  Lines        5564     5564           
=======================================
  Hits         3978     3978           
  Misses       1272     1272           
  Partials      314      314           
Impacted Files Coverage Δ
server/events/vcs/github_client.go 80.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0f265...2f07472. Read the comment docs.

@goodspark goodspark force-pushed the fix-ge-graphql-endpoint branch from 37465a9 to be79419 Compare June 3, 2020 18:19
@goodspark goodspark marked this pull request as ready for review June 3, 2020 18:24
Partially addresses runatlantis#1009, but doesn't fix it entirely. The 406 response
is still a puzzler.
@goodspark goodspark force-pushed the fix-ge-graphql-endpoint branch from be79419 to 2f07472 Compare June 3, 2020 18:35
@lkysow lkysow merged commit 25cd66d into runatlantis:master Jun 3, 2020
@goodspark goodspark deleted the fix-ge-graphql-endpoint branch June 3, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants