-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fetching gh app user. (#30) #1334
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
==========================================
- Coverage 70.05% 70.01% -0.04%
==========================================
Files 74 74
Lines 5540 5556 +16
==========================================
+ Hits 3881 3890 +9
- Misses 1303 1307 +4
- Partials 356 359 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes the problem seen in: #1161
Atlantis running through a GH app is not configured to return a user which is necessary when hiding comments on a PR. When providing GHAppSlug, Atlantis can fetch the app name and then use that to infer the username to filter comments by. Unsure if I missed anything here or if there are unusual use cases where the user can't be tied to the app name but this seems to work for our use case.
Note, in order to ensure I'm not breaking any existing configurations I've made this feature optional. If app slug is not provided the user continues to return an empty string. If this is undesired I can make a breaking change. Will update documentation in a follow up.