Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in allowed_workflows logic #1377

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

netguino
Copy link
Contributor

This fixes a bug where it was required to set allow_custom_workflows in order to validate that the workflows were whitelisted.

If the repo is allowed custom workflows and selects one that is not whitelisted server-side we verify that the repo has defined it.

Fixes Issue 1358

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #1377 (4540f18) into master (a95a194) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1377   +/-   ##
=======================================
  Coverage   69.99%   69.99%           
=======================================
  Files          74       74           
  Lines        5575     5576    +1     
=======================================
+ Hits         3902     3903    +1     
  Misses       1310     1310           
  Partials      363      363           
Impacted Files Coverage Δ
server/events/yaml/valid/global_cfg.go 89.72% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95a194...4540f18. Read the comment docs.

@jamengual jamengual merged commit 434b4f5 into runatlantis:master Jan 31, 2021
@netguino netguino deleted the FixAllowedWorkflows branch January 31, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue restricting what workflows each repo has access to
2 participants