-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade Git clone locking mechanism to go1.19 #2521
Conversation
Tests fail because:
This is because it ain't using Feel free to upgrade this PR to 1.19, maintainer edits are enabled. |
thanks @ribejara-te we will work on this soon. |
@ribejara-te please fix conflicts and rebase/merge from the default branch. Atlantis is now using go1.19. |
How do we get this fixed? @nitrocode |
Ah that is located here Lines 5 to 6 in ec995dd
And the latest testing-env is 2022-11-13 I tried bumping this over the weekend and saw some test failures so if you do require using the latest testing environment then you will need to troubleshoot those and fix unfortunately. |
@ribejara-te I updated to our latest testing-env image today and merged your branch with the default branch. |
cc: @jamengual @chenrui333 please review in case I'm missing something. Is this change safe? Or will it break existing functionality? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but let's get a second opinion too before merging
Thank you @ribejara-te ! |
Co-authored-by: nitrocode <[email protected]>
No description provided.