Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go 1.19 #2670

Merged
merged 2 commits into from
Nov 13, 2022
Merged

Use go 1.19 #2670

merged 2 commits into from
Nov 13, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Nov 13, 2022 •
edited
Loading

what

  • Use go 1.19
  • Bump docker-base to alpine 3.16.3
  • Remove redundant /etc/nsswitch.conf configuration

why

  • Latest golang
  • Use latest alpine and remove /etc/nsswitch.conf configuration since this is now the default in 3.16.3

references

commands

$ docker run -it alpine:3.16.3 sh -c "cat /etc/nsswitch.conf"
# musl itself does not support NSS, however some third-party DNS
# implementations use the nsswitch.conf file to determine what
# policy to follow.
# Editing this file is not recommended.
hosts: files dns

@nitrocode nitrocode marked this pull request as ready for review November 13, 2022 03:36
@nitrocode nitrocode requested a review from a team as a code owner November 13, 2022 03:36
jamengual
jamengual reviewed Nov 13, 2022
View reviewed changes
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitrocode nitrocode merged commit ff3f721 into runatlantis:master Nov 13, 2022
@nitrocode nitrocode deleted the go-1.19 branch November 13, 2022 03:58
This was referenced Nov 13, 2022
Merged
Merged
chenrui333
chenrui333 reviewed Nov 13, 2022
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! 💯

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@nitrocode @krrrr38
Use go 1.19 (runatlantis#2670)
b46f4fa 
* Use go 1.19

* docker-base: bump openssl, git, curl and fix nsswitch
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @chenrui333 @jamengual