Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Switch clone URL structure for *.visualstudio.com URLs for AzureDevOps #2810

Merged
merged 5 commits into from
Dec 19, 2022

Conversation

jsw1993
Copy link
Contributor

@jsw1993 jsw1993 commented Dec 17, 2022

what

Azure DevOps changed their repo structure to dev.azure.com/{organization}. The current code means the legacy {organization}.visualstudio.com URLs do not work as an invalid clone URL is generated

why

Currently URLs using the legacy {organization}.visualstudio.com domain cause clone URLs like {organization.visualstudio.com/{organization}/{project}/_git/{repo} to be generated however the second organization makes these invalid.

This change removes this just for the legacy URLs. Please feel free to recommend a different way to do this

references

@jsw1993 jsw1993 requested a review from a team as a code owner December 17, 2022 19:37
@jsw1993 jsw1993 force-pushed the ADO-Fixes branch 2 times, most recently from 68a61e0 to f5ad1ae Compare December 17, 2022 19:42
@nitrocode nitrocode merged commit 71819a2 into runatlantis:main Dec 19, 2022
@nitrocode
Copy link
Member

Thank you very much for your contribution @jsw1993!!! Please feel free to propose new changes!

@jsw1993
Copy link
Contributor Author

jsw1993 commented Dec 19, 2022

@nitrocode no problem at all. Many thanks for your support and quick response on this. Also for your hard work maintaining this brilliant project. Best regards.

@nitrocode nitrocode added this to the 0.22.0 milestone Dec 23, 2022
@nitrocode nitrocode changed the title Switch clone URL structure for *.visualstudio.com URLs for AzureDevOps bugfix: Switch clone URL structure for *.visualstudio.com URLs for AzureDevOps Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure DevOps cannot clone repo in non-default structure
2 participants