Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (workflow-hook): Make Unique Output IDs for Separate Pre and Post Workflow Hooks #3454

Merged
merged 1 commit into from
May 26, 2023

Conversation

X-Guardian
Copy link
Contributor

what

Moved the generation of the HookID from outside the workflow hook processing loop to inside, so a unique id gets created for each hook.

why

tests

repos.yaml

repos:
- id: /.*/
  pre_workflow_hooks:
    - description: pre workflow test 1
      run: echo "pre workflow test 1"
    - description: pre workflow test 2
      run: echo "pre workflow test 2"
  post_workflow_hooks:
    - description: post workflow test 1
      run: echo "post workflow test 1"
    - description: post workflow test 2
      run: echo "post workflow test 2"

GitHub Checks

image

Pre Workflow Test 1 Output

image

Pre Workflow Test 2 Output

image

Post Workflow Test 1 Output

image

Post Workflow Test 2 Output

image

@X-Guardian X-Guardian requested a review from a team as a code owner May 26, 2023 10:52
@github-actions github-actions bot added the go Pull requests that update Go code label May 26, 2023
@GenPage GenPage merged commit 998eb63 into runatlantis:main May 26, 2023
@X-Guardian X-Guardian deleted the workflow-hook-outputid-fix branch May 26, 2023 13:53
@nitrocode nitrocode added this to the v0.24.2 milestone May 31, 2023
mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output from Separate Pre and Post Workflow Hooks are Logged to the same Output ID
3 participants