-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Automerge Types #466
Conversation
For repos with certain merge methods disabled (such as 'merge'), simply hitting the GitHub `/merge` endpoint is not sufficient. Instead, we need to check which methods are actually available, then use the appropriate method. With this change it will: 1. Default to 'merge' if enabled 2. Use 'rebase' if 'merge' is disabled and rebase is enabled 3. Use 'squash' if 'merge' is disabled
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=========================================
+ Coverage 70.53% 70.6% +0.06%
=========================================
Files 63 63
Lines 4243 4259 +16
=========================================
+ Hits 2993 3007 +14
- Misses 1028 1029 +1
- Partials 222 223 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
allowSquash bool | ||
expMethod string | ||
}{ | ||
"all true": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
For repos with certain merge methods disabled (such as 'merge'), simply
hitting the GitHub
/merge
endpoint is not sufficient. Instead, we needto check which methods are actually available, then use the appropriate
method.
With this change it will:
Notes: