chore: Fix build CI mismatch #5253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Massa <[email protected]>
lukemassa
requested review from
GenPage,
nitrocode and
X-Guardian
and removed request for
a team
Signed-off-by: Luke Massa <[email protected]>
lukemassa
force-pushed
the
fix_test_build
branch
from
ce87111 to
cc05a5f
Compare
jamengual
approved these changes
Jan 19, 2025
X-Guardian
added a commit
that referenced
this pull request
Jan 26, 2025
This reverts commit 3e52125.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Fix strategy so "skip build" has same matrix as "test" for build.
why
Otherwise these checks are never satisfied in situations where the build doesn't occur
tests
This PR is not a good test of itself, since it changes the github CI file, thus triggering the builds explicitly :). After this is merged, I'll try another PR that shouldn't trigger a build and we'll confirm they are "skipped"
references