chore: Clarify logs in determining merged project configs #5255
+6
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Massa <[email protected]>
Signed-off-by: Luke Massa <[email protected]>
lukemassa
requested review from
chenrui333,
nitrocode and
X-Guardian
and removed request for
a team
dosubot
bot
added
the
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Collapse and clarify logs in determining merged project configs.
why
I didn't quite understand this when going through #5245, but the logs and comments under automatic detection made it seem like it was conditional on other projects not being found, however that's not the case. If automatic detection is enabled, we simply run it. Maybe that used to be the case, but now this log and comment is a bit misleading and redundant.
This also allowed fewer parameters to be passed into this function, which feels more correct to me; it's a detail that this function doesn't quite "know" that the reason hasRepoCfg is false is that it couldn't find the file. That logging can and should happen closer to when the parsing actually happens.
tests
Normal CI
references