fix: Unintentional nil errors in azuredevops client #5312
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
Signed-off-by: Luke Massa <[email protected]>
lukemassa
force-pushed
the
fix_errors_in_azuredevops_client
branch
from
65a4959 to
1a01b3e
Compare
lukemassa
changed the title
lukemassa
changed the title
jamengual
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Fix some errors in azuredevops that are unintentionally returning nil.
why
Each of these call sites is proceeded by
if err != nil { return }, so if we reach these lines of code, we know thaterrisnil. However,errors.Wrapis documented to return nil if err is nil. https://pkg.go.dev/github.com/pkg/errors#Wrap. This means we are actually returning anilerror in these cases, which is not intentionaltests
Unit tests.
references
Found while working on #5269.
Similar issue to #5294.