Initial Kustomize work

[tobbbles]

Towards #424.

Here I provide a base bundle.yaml that I took from the example in the documentation. Ideally, I'd prefer to generate this with a script upon release to update the container image.

I've provided some base structural documentation of what envvars need to be patched from the kustomize manifest.

I'd love to hear some feedback and how we can continue on this. Thanks!

[codecov]

Codecov Report

Merging #785 into master will increase coverage by 0.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   71.83%   72.78%   +0.95%     
==========================================
  Files          65       63       -2     
  Lines        5213     4807     -406     
==========================================
- Hits         3745     3499     -246     
+ Misses       1183     1050     -133     
+ Partials      285      258      -27

Impacted Files	Coverage Δ
server/events/models/models.go	74.6% <0%> (-0.4%)	⬇️
server/events/yaml/parser_validator.go	96.66% <0%> (-0.15%)	⬇️
server/events/comment_parser.go	95.2% <0%> (-0.08%)	⬇️
server/locks_controller.go	87.14% <0%> (ø)	⬆️
server/events/vcs/proxy.go	0% <0%> (ø)	⬆️
server/user_config.go	100% <0%> (ø)	⬆️
server/events/vcs/azuredevops_client.go
server/azuredevops_request_validator.go
cmd/server.go	79.42% <0%> (+0.65%)	⬆️
server/events/project_command_builder.go	83.01% <0%> (+0.89%)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777956c...78d01f8. Read the comment docs.

[lkysow]

Nice work!

Can you put the files inside a kustomize/ directory? Do they need to be at the root?

[lkysow]

spacing is off here

[lkysow]

Can you follow the same pattern as the Kubernetes manifest deployment instructions and use

        image: runatlantis/atlantis:v<VERSION> # 1. Replace <VERSION> with the most recent release.

Then include this in your patch instructions? Or how do kustomize templates usually work? If that's not possible then add updating this file to the release instructions in CONTRIBUTING.md

[tobbbles]

We can - however from most examples I see, a lot of these bundles will be generated upon release and include the latest version in the bundle/kustomization file. It gives the user the a way to run the remote resource without any manifest issues. Sure, Atlantis won't run if they don't patch the environment variables - however that's the application failing here, rather than the actual Kubernetes manifest.

Let me know your thoughts on this.

[lkysow]

That makes sense. Can you add a bullet to our CONTRIBUTING.md file under "releases" to say update the kustomize/bundle.yaml file. You'll see we already say to update main.go.

[tobbbles]

I believe the kustomization.yaml file has to be in the root of the project.

We could move the bundle into it's own directory

[lkysow]

I believe the kustomization.yaml file has to be in the root of the project.

We could move the bundle into it's own directory

In that doc they use target="github.com/kubernetes-sigs/kustomize//examples/multibases/dev/?ref=v1.0.6" which doesn't have kustomize.yaml at its root so I think it's fine to move everything under a kustomize/ directory.

[tobbbles]

Thanks for the feedback - updated the documentation accordingly along with the requested changes.

[lkysow]

Great work!

[lkysow]

Can you squash your commits and then we're ready to merge.

[tobbbles]

Thanks - squashed down for merging. 👍