feat: add servicemonitor additonal labels #354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add additional Kubernetes labels to the ServiceMonitor as this is often required by the Prometheus operator to identify the Service and pod(s).
why
The current configuration does not support adding labels to the Service Monitor. To add these labels in the case of adding a label for the Prometheus Operator, kustomize can be used or maintaining a separate resource for
ServiceMonitor
which is unnecessarily complex.tests
Helm templates with
servicemonitor.enabled
set totrue
with testadditionalLabels
references
#353 -> Link to a Issue :)