Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed runAsUser uid #359

Closed
wants to merge 1 commit into from
Closed

fix: Changed runAsUser uid #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/atlantis/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ statefulSet:
labels: {}
securityContext:
fsGroup: 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss if this is the right thing to do.
We made changes to Alpine and Debian to match the UID recently and we need to keep backwards compatibility
this could affect users that are not enforcing the default.

@GenPage @GMartinez-Sisti @nitrocode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be closed. There’s another PR fixes the uid to be 100 on both -> runatlantis/atlantis#4304. Please let us know what you think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to merging #4304, is this fix #359 even needed when the values can be overridden for runAsUser?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If runatlantis/atlantis#4304 gets merged in its current state this won't be necessary anymore no.

runAsUser: 100
runAsUser: 1000
fsGroupChangePolicy: "OnRootMismatch"
priorityClassName: ""
updateStrategy: {}
Expand Down
Loading