fix: fix values.schema.json for extraArgs #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvanzuijlen
changed the title
kvanzuijlen
changed the title
|
pfft im over here troubleshooting and tracking down the problem and you ninja a PR for the change <3 |
|
Hi @kvanzuijlen, this was indeed by mistake, thank you for the fix 🙏. We can add a CI test file to create these annotations and make sure this doesn’t get reverted. If you can add it to the PR I appreciate it, otherwise we’ll do it later. |
|
Hi @GMartinez-Sisti, I was already planning on adding some CI tests (not only for this one) at a later moment, but I won't be available for the next 2 weeks. |
Whenever you can it's perfect 😄. Thank you! |
GMartinez-Sisti
approved these changes
Mar 11, 2024
GMartinez-Sisti
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Fixes #365. This changes the array item type back to string for extraArgs, which seems to have been erroneously changed in #356
why
Even if this wasn't erroneously, it should've been a breaking change.
tests
references