fix(templates): Fix and boolean on line 44 of statefulset.yaml

[tmessinis]

what

Helm templating syntax requires that the boolean keyword goes before the two values that are being compared.
Example:

{{if and value1 value2}}

instead of

{{if value1 and value2}}

why

This fixes the issue with respect to the following error when upgrading the helm chart:

Error: UPGRADE FAILED: template: atlantis/templates/statefulset.yaml:44:47: executing "atlantis/templates/statefulset.yaml" at <.Values.dnsPolicy>: dnsPolicy is not a method but has arguments

tests

This fix has been tested locally and the manifests render out properly.

references

closes #405

[GMartinez-Sisti]

Hi @tmessinis, thanks for the fix! Unfortunately it appears there is an issue with a CI job. I can’t tell if it’s due to this change, although highly unlikely, but we need to fix it before merging this. Even if it’s on another PR.

[tmessinis]

Hey @GMartinez-Sisti, based on some local testing that I did, the size of the init-shared-path emptyDir was too small to hold both the terragrunt and terragrunt-atlantis-config binaries downloaded by the init container and the atlantis pod was getting evicted. This had the side effect of making the helm test command fail, since there was no pod for the service to forward the request to and for curl to fail because of it.

[GMartinez-Sisti]

Hey @GMartinez-Sisti, based on some local testing that I did, the size of the init-shared-path emptyDir was too small to hold both the terragrunt and terragrunt-atlantis-config binaries downloaded by the init container and the atlantis pod was getting evicted. This had the side effect of making the helm test command fail, since there was no pod for the service to forward the request to and for curl to fail because of it.

Awesome finding! Thanks for the effort. Please check the CI log as now we just need to sync the docs with the new change.

[tmessinis]

Hey @GMartinez-Sisti, the readme has been updated. Is there something else I need to update as well?