Select update channels

[AaronDewes]

Depends on runcitadel/manager#122

[pwltr]

There is a bug in the manager code for this:
https://github.com/runcitadel/manager/blob/3205e4c096a806f1afd87fdf4a4eb4e33b83b152/routes/v2/system.ts#L154

ctx.body.channel should be ctx.request.body.channel

But after fixing this the endpoint still returns error 404, even though it seems to work otherwise. I'll do another test run when fixed.

[pwltr]

As a suggestion it would be better if we could merge "per feature" instead of backend first and then frontend like we did for this feature. Would enable us to test E2E and more easily find bugs. We probably would catch any major bugs in pre-release testing anyway but I think it would avoid us having to do too many reviews and jumping from repo to repo.

[pwltr]

Switching works now but there are still some issues:

• GET /update-channel returns the wrong update channel after changing it => need to rebuild all containers with updated config?
• After opening & closing the ChannelSelector modal you can't open it anymore
• Could add some error handling in the frontend

[AaronDewes]

* GET /update-channel returns the wrong update channel after changing it => need to rebuild all containers with updated config?

runcitadel/core@15138ab should fix this.

* After opening & closing the ChannelSelector modal you can't open it anymore

I'll debug that, thanks for letting me know!

* Could add some error handling in the frontend

👍

[pwltr]

After opening & closing the ChannelSelector modal you can't open it anymore

This works now if the modal is closed with the close button but still broken when closing with a click outside the modal.

It still doesn't actually switch the branch or does the update as far as I can see, it only writes the env var. The dashboard reloads once, is unresponsive, then reloads again and asks for login. Nothing seems to have changed though.

Tested with this branch and the feat/quick-updates branch on core.

[AaronDewes]

It still doesn't actually switch the branch or does the update as far as I can see, it only writes the env var.

It is only supposed to make updates from the branch available, not actually install them.

[AaronDewes]

This works now if the modal is closed with the close button but still broken when closing with a click outside the modal.

I'll try to fix that too, thanks!

[pwltr]

It is only supposed to make updates from the branch available, not actually install them.

I find that confusing. How can I actually switch the branch then from the UI? I'd have to wait until a new update comes out on that branch? We should at least make it clear to the user that that is what is happening. But imo just auto-install the update.

Also switching to Core LN doesn't work because the env has the wrong name:
UPDATE_CHANNEL=core-ln => needs to match the github branch c-lightning