RUN-301 Encode user metadata to URL format to avoid error on upload request to S3 log storage #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosrfranco
requested review from
ltamaster
and removed request for
ltamaster
ltamaster
reviewed
Aug 9, 2021
There was a problem hiding this comment.
it worked as expected.
@carlosrfranco please add the documentation of the new flag in the README.md
ltamaster
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/rundeckpro/rundeckpro/issues/1920
Special characters on user metadata causes error on the upload request to S3 log storage.
To fix it, was included a new config property
encodeUserMetadatathat, iftrue, will encode all user metadata to URL format.