Collection Log Luck v1.2.0 #7458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect stale collectionlog.net data to fix calculations when viewing log Update luck without having to relog after each kill / drop Hueycoatl and Royal Titans Wintertodt rework, Moxi, special items like Tempoross, GoTR Misc bug fixes
|
|
A couple of additional fixes
|
I'm going to merge this since it's not new, but you're still using System.out or System.err somewhere if you can please switch them to slf4j or remove them in another change. |
|
Thanks. I don't see any usages besides two commented-out lines in CollectionLogDeserializer.javs which I temporarily uncomment once per update to detect new items. It never makes it into a release. Not sure why the tool is complaining about commented out lines... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect stale collectionlog.net data to fix calculations when viewing log
Update luck without having to relog after each kill / drop
Hueycoatl and Royal Titans
Wintertodt rework, Moxi, special items like Tempoross, GoTR
Misc bug fixes