Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inventory-notifier #7520

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

dandylyon
Copy link
Contributor

Updated for current RuneLite API.

@runelite-github-app
Copy link

@Felanbird
Copy link
Contributor

We would prefer you to keep a linear history, it's going to take longer to review if you force push your changes and we have to review the entire plugin, again.

@LlemonDuck
Copy link
Contributor

Yeah ^ please rework your commits to have a linear history since there's no need here for a new git timeline.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 25, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 25, 2025
@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 25, 2025
@dandylyon
Copy link
Contributor Author

Hi,

I’m not that proficient with Git, and deleting the old branch was suggested as a fix for the errors I was running into—it seems to have resolved them. I’m not sure how I’d go about restoring old history.

That said, this is a pretty small/basic plugin, and almost everything was rewritten, so I don’t think much of the original code remains. Please let me know if there’s anything specific you’d like me to do.

Thanks!

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 25, 2025
@tylerwgrass
Copy link
Member

You might be able to recover using a commit you used in one of the other PRs you closed (which you don't need to do btw, just update your existing PR).

You might also be able to find an older state to reset to using git reflog.

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin change waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants