fix: make tests backwards compatible with nerdctl v1 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
make-tests-nerdctlv1-compatible
branch
from
47faa7c to
5a4bd56
Compare
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
make-tests-nerdctlv1-compatible
branch
from
5a4bd56 to
43a5702
Compare
Kern--
approved these changes
Jan 3, 2025
|
Going to pull this in. Happy to go comeback and iterate on this more if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
nerdctl v2 rollout is quick for macOS and Windows, but slow for Linux (~weeks).
Description of changes:
This change enables test runners to specify the nerdctl version depending on the runtime for that platform and tests will run accordingly.
Testing done:
Ran in runfinch/finch#1237
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.