Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add distribution API (with bug fix) #121

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

pendo324
Copy link
Member

Issue #, if available:

Description of changes

This is largely the same as #92, but with e2e tests added, and a small diff for a bugfix and to conform to the status codes returned by other existing implementations.

Testing done

  • Unit tests for new API handler (76%) and service (85%)
  • e2e tests, including auth/unauth scenarios
  • Manual testing using docker-py, and comparison to other implementations

Contribution agreement

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pendo324 pendo324 self-assigned this Dec 17, 2024
@pendo324 pendo324 added the enhancement New feature or request label Dec 17, 2024
Shubhranshu153
Shubhranshu153 previously approved these changes Dec 20, 2024
swagatbora90
swagatbora90 previously approved these changes Dec 20, 2024
Copy link
Contributor

@swagatbora90 swagatbora90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the e2e tests.

pendo324 and others added 3 commits December 20, 2024 21:13
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
@pendo324 pendo324 force-pushed the fix-distribution-api branch from e71f91a to aa1a06e Compare December 20, 2024 21:13
coderbirju
coderbirju previously approved these changes Dec 20, 2024
@coderbirju coderbirju enabled auto-merge (squash) December 20, 2024 21:46
@coderbirju coderbirju merged commit da0dab7 into runfinch:main Dec 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants