-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add distribution API (with bug fix) #121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubhranshu153
previously approved these changes
Dec 20, 2024
swagatbora90
previously approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the e2e tests.
Signed-off-by: Justin <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
pendo324
force-pushed
the
fix-distribution-api
branch
from
December 20, 2024 21:13
e71f91a
to
aa1a06e
Compare
coderbirju
previously approved these changes
Dec 20, 2024
Kern--
reviewed
Dec 20, 2024
Signed-off-by: Justin Alvarez <[email protected]>
pendo324
dismissed stale reviews from coderbirju, swagatbora90, and Shubhranshu153
via
December 20, 2024 22:07
fd9cd2f
Kern--
approved these changes
Dec 20, 2024
coderbirju
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes
This is largely the same as #92, but with e2e tests added, and a small diff for a bugfix and to conform to the status codes returned by other existing implementations.
Testing done
Contribution agreement
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.