Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add distribution API #92

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

pendo324
Copy link
Member

@pendo324 pendo324 commented Nov 7, 2024

Issue #, if available:

Description of changes

Testing done

  • Unit tests for new API handler (76%) and service (85%)
  • Manual testing using docker-py, and comparison to other implementations

Contribution agreement

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Justin Alvarez <[email protected]>
@pendo324 pendo324 added the enhancement New feature or request label Nov 7, 2024
@pendo324 pendo324 requested review from Kern-- and henry118 November 7, 2024 20:57
@pendo324 pendo324 self-assigned this Nov 7, 2024
Signed-off-by: Justin Alvarez <[email protected]>
@pendo324 pendo324 requested a review from Kern-- November 8, 2024 21:00
@Shubhranshu153
Copy link
Contributor

nit: Requesting change heading to Image Distribution API (Distribution API in itself is a thing)

@Shubhranshu153
Copy link
Contributor

LGTM: Should we contribute it to nerdctl long term?

@pendo324 pendo324 merged commit 0e413d7 into runfinch:main Nov 13, 2024
7 checks passed
swagatbora90 added a commit to swagatbora90/finch-daemon that referenced this pull request Nov 27, 2024
swagatbora90 added a commit to swagatbora90/finch-daemon that referenced this pull request Nov 27, 2024
This reverts commit 0e413d7.

Signed-off-by: Swagat Bora <[email protected]>
swagatbora90 added a commit to swagatbora90/finch-daemon that referenced this pull request Nov 27, 2024
This reverts commit 0e413d7.

Signed-off-by: Swagat Bora <[email protected]>
swagatbora90 added a commit that referenced this pull request Nov 27, 2024
This reverts commit 0e413d7.

Signed-off-by: Swagat Bora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants