Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update containerd and nerdctl v2 #148

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

swagatbora90
Copy link
Contributor

Issue #, if available:

Previously opened PR #98

Description of changes:
(Copied from original PR)

Updated libraries to use containerd 2.0 and nerdctl 2.0. This includes some functionality changes on nerdctl's end so I had to do some code changes to keep as similar behavior as possible.

FUNCIONALITY CHANGES:

  • finch remove will only send a 400 now on error, as nerdctl no longer returns a specific error, instead returning a generic one (some volumes could not be removed) and having the specific error in the WARN logs. Not sure if there's a way around it, though. Changes e2e test to reflect this but not unit test.
  • Namespacing has been added at a wider scale, so things such as networks can now be namespaced. This means that the way files are stored in the backend.
    • This change makes finch-daemon incompatible with nerdctl <2.0.0.

The first two commits should only include imports and package name changes and no real code functionality changes. The third commit should have all of the functionality changes (as well a couple of package name changes that I missed + changes I needed after rebasing, sorry 😔)

Testing done:
make test-unit

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@swagatbora90 swagatbora90 marked this pull request as ready for review January 24, 2025 21:37
pendo324
pendo324 previously approved these changes Jan 27, 2025
austinvazquez
austinvazquez previously approved these changes Jan 31, 2025
austinvazquez
austinvazquez previously approved these changes Feb 3, 2025
@swagatbora90 swagatbora90 merged commit d3db35e into runfinch:main Feb 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants