-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update containerd and nerdctl v2 #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagatbora90
force-pushed
the
update-nerdctl-v2
branch
from
January 24, 2025 21:21
bb1ec31
to
1492e96
Compare
pendo324
reviewed
Jan 24, 2025
pendo324
previously approved these changes
Jan 27, 2025
austinvazquez
previously approved these changes
Jan 31, 2025
swagatbora90
dismissed stale reviews from austinvazquez and pendo324
via
January 31, 2025 21:18
c789c56
1 task
austinvazquez
previously approved these changes
Feb 3, 2025
Signed-off-by: David Son <[email protected]>
Signed-off-by: David Son <[email protected]>
Signed-off-by: David Son <[email protected]>
…ctl versions Signed-off-by: Swagat Bora <[email protected]>
swagatbora90
force-pushed
the
update-nerdctl-v2
branch
from
February 5, 2025 19:02
c789c56
to
79a6602
Compare
pendo324
approved these changes
Feb 5, 2025
austinvazquez
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Previously opened PR #98
Description of changes:
(Copied from original PR)
Updated libraries to use containerd 2.0 and nerdctl 2.0. This includes some functionality changes on nerdctl's end so I had to do some code changes to keep as similar behavior as possible.
FUNCIONALITY CHANGES:
finch remove
will only send a 400 now on error, as nerdctl no longer returns a specific error, instead returning a generic one (some volumes could not be removed
) and having the specific error in the WARN logs. Not sure if there's a way around it, though. Changes e2e test to reflect this but not unit test.The first two commits should only include imports and package name changes and no real code functionality changes. The third commit should have all of the functionality changes (as well a couple of package name changes that I missed + changes I needed after rebasing, sorry 😔)
Testing done:
make test-unit
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.