Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clean up everything before each run #30

Merged
merged 3 commits into from
Nov 23, 2022

Conversation

davidhsingyuchen
Copy link
Contributor

@davidhsingyuchen davidhsingyuchen commented Nov 23, 2022

Summary

Currently if a run is canceled midway, the environment is left untidied, which may cause subsequent runs to fail. Take this run for example, _output was not cleaned up, so the run failed.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Hsing-Yu (David) Chen <[email protected]>
Signed-off-by: Hsing-Yu (David) Chen <[email protected]>
@davidhsingyuchen davidhsingyuchen marked this pull request as ready for review November 23, 2022 02:15
Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@davidhsingyuchen davidhsingyuchen enabled auto-merge (squash) November 23, 2022 18:45
@davidhsingyuchen davidhsingyuchen merged commit 7e549b3 into runfinch:main Nov 23, 2022
@davidhsingyuchen davidhsingyuchen deleted the fix-flaky-test branch November 23, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants