Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix darwin tests #596

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: fix darwin tests #596

merged 1 commit into from
Oct 4, 2023

Conversation

vsiravar
Copy link
Contributor

@vsiravar vsiravar commented Oct 4, 2023

Issue #, if available:

Description of changes:

  • fix unit tests for darwin
  • multi line comment for golinter
  • remove duplicate test in config_test.go

Testing done:
Yes, locally.

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Vishwas Siravara <[email protected]>
@vsiravar vsiravar merged commit 83c5376 into windev Oct 4, 2023
@vsiravar vsiravar deleted the vsiravar/fix-darwin-tests branch October 4, 2023 23:24
vsiravar added a commit that referenced this pull request Oct 17, 2023
Issue #, if available:

*Description of changes:*
- fix unit tests for darwin 
- multi line comment for golinter
- remove duplicate test in config_test.go

*Testing done:*
Yes, locally. 


- [X] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Vishwas Siravara <[email protected]>
vsiravar added a commit that referenced this pull request Oct 17, 2023
Issue #, if available:

*Description of changes:*
- fix unit tests for darwin
- multi line comment for golinter
- remove duplicate test in config_test.go

*Testing done:*
Yes, locally.

- [X] I've reviewed the guidance in CONTRIBUTING.md

#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Vishwas Siravara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants